Name: Specfact Code Review
Author: nold-ai

House Rules - AI Coding Context (v4)

Updated: 2026-03-30 | Module: nold-ai/specfact-code-review

DO

Ask whether tests should be included before repo-wide review; default to excluding tests unless test changes are the target
Use intention-revealing names; avoid placeholder public names like data/process/handle
Keep functions under 120 LOC, shallow nesting, and <= 5 parameters (KISS)
Delete unused private helpers and speculative abstractions quickly (YAGNI)
Extract repeated function shapes once the second copy appears (DRY)
Split persistence and transport concerns instead of mixing repository.* with http_client.* (SOLID)
Add @require/@ensure (icontract) + @beartype to all new public APIs
Run hatch run contract-test-contracts before any commit
Write the test file BEFORE the feature file (TDD-first)
Return typed values from all public methods and guard chained attribute access

Updated: 2026-03-30 | Module: nold-ai/specfact-code-review

Ask whether tests should be included before repo-wide review; default to excluding tests unless test changes are the target
Use intention-revealing names; avoid placeholder public names like data/process/handle
Keep functions under 120 LOC, shallow nesting, and <= 5 parameters (KISS)
Delete unused private helpers and speculative abstractions quickly (YAGNI)
Extract repeated function shapes once the second copy appears (DRY)
Split persistence and transport concerns instead of mixing repository.* with http_client.* (SOLID)
Add @require/@ensure (icontract) + @beartype to all new public APIs
Run hatch run contract-test-contracts before any commit
Write the test file BEFORE the feature file (TDD-first)
Return typed values from all public methods and guard chained attribute access