Review Checklist

Redundancy. Is any assertion already logically covered by another test? Flag duplicates.
Coverage gaps. Read the production code the tests cover. List branches/behaviors that have no test.
Minimality. For each test, could any setup line or assertion be removed without the test losing its purpose? If yes, flag it.
Naming. Test names should describe behavior: test "#method does X when Y". Flag vague names ("handles correctly", "works properly") or names that describe scope instead of behavior.
Variable naming. Variables should reflect domain meaning, not type-system classification. resolver not type, converted_amount not result.
Structure. Tests belong in the existing test file. Flag unnecessary nested classes, separate files, or duplicate setup that could be a shared helper.
Convention. Compare against how other components test the same pattern. Flag deviations from the strongest codebase convention.

Review tests that were recently written or changed in the current conversation.

Redundancy. Is any assertion already logically covered by another test? Flag duplicates.
Coverage gaps. Read the production code the tests cover. List branches/behaviors that have no test.
Minimality. For each test, could any setup line or assertion be removed without the test losing its purpose? If yes, flag it.
Naming. Test names should describe behavior: test "#method does X when Y". Flag vague names ("handles correctly", "works properly") or names that describe scope instead of behavior.
Variable naming. Variables should reflect domain meaning, not type-system classification. resolver not type, converted_amount not result.
Structure. Tests belong in the existing test file. Flag unnecessary nested classes, separate files, or duplicate setup that could be a shared helper.
Convention. Compare against how other components test the same pattern. Flag deviations from the strongest codebase convention.

Review Tests