Learn From Pr

Identify corrections — look for:

• Reviewer pointing out a mistake or bad pattern
• Suggestions to do something differently
• Change requests that imply a general rule
• Skip: approvals, questions, nitpicks with no generalizable lesson

Ensure the file hierarchy exists. If docs/mistakes.md does not exist, create it:

# Mistakes Log

Raw log of mistakes made during development.

## Mistake Taxonomy

| Type | When to use |
|------|-------------|
| `architectural` | Wrong structure, violated patterns, bad module boundaries |
| `implementation` | Wrong API usage, incorrect logic, bad types, wrong library |
| `process` | Wrong commands, skipped steps, wrong git workflow |
| `planning` | Misread requirements, missed scope, over-engineered |

## Promotion Threshold

Promote to `.claude/rules/mistakes.md` when **either**:
- The **same pattern recurs** a 2nd time, OR
- The mistake **generalizes across >1 feature area**

## Entry Format

### YYYY-MM-DD — [Short description]
**Type:** architectural | implementation | process | planning
**Source:** PR #N review by @reviewer | in-session correction
**What went wrong:** ...
**Why:** ...
**New rule:** ALWAYS/NEVER ...
**Status:** raw | [PROMOTED → .claude/rules/mistakes.md YYYY-MM-DD]

---

## Entries

<!-- New entries go here, newest first -->

If .claude/rules/mistakes.md does not exist, create it:

# Rules Promoted from Mistakes Log

Rules extracted from `docs/mistakes.md` after a pattern recurred or generalized.

**Source log:** docs/mistakes.md

## Promotion Threshold

Promote when **either** condition is met:
1. Same mistake pattern occurs a **2nd time**
2. Pattern **generalizes across >1 feature area** (not isolated to one file/route)

---

<!-- Promoted rules go here, newest first -->

Draft entries for docs/mistakes.md (one per correction):

### YYYY-MM-DD — [Short description]
**Type:** [architectural|implementation|process|planning]
**Source:** PR #$ARGUMENTS review by @reviewer
**What went wrong:** [what the reviewer flagged]
**Why:** [root cause]
**New rule:** ALWAYS/NEVER [actionable rule]
**Status:** raw

Show drafted entries to the user. Ask: "Add these to docs/mistakes.md?"

If confirmed, prepend entries to docs/mistakes.md under ## Entries (newest first).

Check for promotion: Search docs/mistakes.md for similar past entries.

• If this is the 2nd+ occurrence of the same pattern → promote
• If the rule generalizes across >1 feature area → promote
• Otherwise: stop here. The rule stays as raw in docs/mistakes.md.

If promoting: Ask the user: "This pattern has occurred before. Promote to .claude/rules/mistakes.md?"

• If confirmed, add a standing rule to .claude/rules/mistakes.md:

  ## [Topic]
  - ALWAYS/NEVER [rule] — promoted from docs/mistakes.md on YYYY-MM-DD
  

• Update the entry in docs/mistakes.md: change **Status:** raw to **Status:** [PROMOTED → .claude/rules/mistakes.md YYYY-MM-DD]

If no actionable corrections found, say so. Not every review contains generalizable rules.