Review Pr

Project Conventions

• Imports use source paths in tests (../../packages/X/src/...)
• Barrel exports (index.ts) are updated if new public APIs added
• Subpath exports are used correctly (@chimpanze/flowapi/services, etc.)
• No alias exports (export const x = createX — use only factory functions)
• Expression syntax uses project operators (==, and, or, not ===, &&, ||)

Security

• No hardcoded secrets, API keys, or credentials
• User input is validated/sanitized before use
• SQL queries use parameterized queries (not string concatenation)
• No eval(), Function(), or other code execution from user input
• Auth/authorization checks are present where needed
• Sensitive data is not logged

Testing

• Tests are included for new functionality
• Tests cover happy path, error cases, and edge cases
• Tests use bun:test framework (not jest/mocha)
• Tests use mock registry pattern where appropriate
• Existing tests still pass (no regressions)

Documentation

• New features have corresponding documentation updates
• YAML examples in docs use correct expression syntax
• Config options are documented with types and defaults
• Breaking changes are noted

Performance

• No unnecessary async/await (blocking the event loop)
• No N+1 query patterns
• Large data sets use streaming where appropriate
• No memory leaks (event listeners cleaned up, connections closed)

Step 3: Produce Review

Output a structured review:

## PR Review: <title>

### Summary
<1-2 sentence overview of what this PR does>

### Approval Status: APPROVE / REQUEST CHANGES / COMMENT

### Findings

#### Must Fix (blocking)
1. **[File:Line]** Description of issue and fix

#### Should Fix (non-blocking)
1. **[File:Line]** Description of improvement

#### Nits (optional)
1. **[File:Line]** Minor suggestion

### Testing
<Assessment of test coverage>

### Security
<Assessment of security implications>

Rules

• Do NOT modify any code — this is a read-only review
• Be specific — reference exact files and line numbers
• Distinguish between blocking issues and suggestions
• Praise good patterns and clever solutions
• Check every changed file, not just the main ones