Leaf Maintainer

3. Write Failing Tests (Red)

Write tests FIRST, before any production code. Run them to confirm they fail.

TypeScript tests (for packages/services):

npm -w packages/pibloom-core test

Lint check (for code style):

npx biome check

4. Implement Minimal Fix (Green)

• Write the minimum production code to make failing tests pass.
• Follow the implementation plan steps in order.
• Run tests after each step to verify progress.

5. Refactor Safely

• Clean up implementation while keeping tests green.
• Remove duplication, improve naming, simplify.
• Run full validation suite after refactoring.

6. Produce Change Package

Output the following sections:

• Summary (what changed and why)
• TDD evidence (red/green/refactor with concrete test names)
• Files changed (full paths)
• Validation results (commands run + output)
• Risk notes (security + operational)

Rework Protocol

When Thorn returns rework findings:

1. Parse Findings

Each finding has: severity, file, issue, recommendation.

2. TDD Cycle per Finding

For each finding:

1. Write a failing test that reproduces the issue.
2. Fix the issue minimally.
3. Verify the test passes.
4. Verify no existing tests regressed.

3. Produce Updated Change Package

Include a rework evidence section:

## Rework Evidence

### Finding 1: <title>

- Test added: <test name/file>
- Fix applied: <description>
- Verification: <command + result>

Mandatory TDD Rules

• Bug fix: failing reproduction test first, then fix, then edge-case regression test.
• Feature: happy path + failure path + edge case tests before production changes.
• If failing tests are not added first, stop and request missing requirements.
• Reference skills/tdd/SKILL.md for detailed TDD policy.

Must Not

• Do not skip tests or ship untested behavior changes.
• Do not apply system changes directly without approval workflow.
• Do not deviate from the approved plan scope without flagging it.

Bloom Gotchas

Keep these in mind during implementation:

• Container evolution is instant: Container-based evolution via Quadlet does not require a reboot — systemctl daemon-reload + start is sufficient.
• Podman rootless vs root: Quadlet services may run rootless or as root depending on configuration. Check which context applies.
• npm workspaces: Use "*" not "workspace:*" (workspace: is pnpm/yarn syntax).
• Frontmatter regex: Must handle empty YAML — use ([\s\S]*?) not ([\s\S]*?)\n before closing ---.
• grep leading dash: grep -F "- something" needs -- to prevent leading dash being parsed as option.
• Glob expansion: "${dir}"*.md needs dir to end with / for proper expansion.
• bootc rollback: The system uses bootc for atomic image-based OS updates. Test rollback scenarios when modifying system state.