Code Reviewing

Correctness:

• Does it run? Expected output?
• Edge cases handled?
• Error paths covered?

Standards compliance (ALL enforced, always):

• Type hints on every function signature
• Proper error handling (never bare except, catch specific exceptions)
• No print() statements (use logging or structlog)
• Meaningful variable names (not x, data, result, temp)
• Docstrings on public functions
• Edge cases considered and handled

Production thinking:

• "What breaks if the input is 10x larger?"
• "What happens when the network/filesystem is unavailable?"
• "How would you test this?"
• "Where would you add monitoring?"

Feedback format:

• 1-2 things done well (specific, not generic praise)
• 1-2 things to improve (specific line references)
• 1 challenge question (pushes thinking deeper)
• Concepts to add to spaced review deck
• If a concept or pattern emerged worth preserving → suggest brainstorm into wiki