Tdd

3. REFACTOR (Improve)

# Improve code quality (extract, rename, simplify)
# After EACH change:
pnpm vitest run
# Must stay green. If red, revert immediately.

Test Patterns

AAA (Arrange-Act-Assert) — Unit tests

import { describe, it, expect } from "vitest";
import { calculateTotal } from "./cart";

describe("calculateTotal", () => {
  it("should return 0 for empty cart", () => {
    // Arrange
    const items: CartItem[] = [];
    // Act
    const result = calculateTotal(items);
    // Assert
    expect(result).toBe(0);
  });
});

GWT (Given-When-Then) — Behavioral tests

import { describe, it, expect } from "vitest";
import { applyDiscount } from "./cart";

describe("CartCheckout", () => {
  describe("applying discount code", () => {
    it("given a valid 20% code, when applied to 1000 yen cart, then total is 800", () => {
      // Given
      const cart = createCart({ total: 1000 });
      const code = "SAVE20";
      // When
      const result = applyDiscount(cart, code);
      // Then
      expect(result.total).toBe(800);
    });

    it("given an expired code, when applied, then returns error", () => {
      // Given
      const cart = createCart({ total: 1000 });
      const code = "EXPIRED";
      // When
      const result = applyDiscount(cart, code);
      // Then
      expect(result.ok).toBe(false);
      expect(result.error).toBe("DISCOUNT_EXPIRED");
    });
  });
});

AAA vs GWT

Mixing in a project is fine. Stay consistent within a file.

Component Test (vitest + testing-library)

import { render, screen } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import { LoginForm } from "./login-form";

describe("LoginForm", () => {
  it("should show error on invalid email", async () => {
    render(<LoginForm />);
    const input = screen.getByLabelText("Email");
    await userEvent.type(input, "invalid");
    await userEvent.click(screen.getByRole("button", { name: "Submit" }));
    expect(screen.getByText(/invalid email/i)).toBeInTheDocument();
  });
});

E2E Test (Playwright)

import { test, expect } from "@playwright/test";

test("user can log in", async ({ page }) => {
  await page.goto("/login");
  await page.getByLabel("Email").fill("[email protected]");
  await page.getByLabel("Password").fill("password123");
  await page.getByRole("button", { name: "Log in" }).click();
  await expect(page).toHaveURL("/dashboard");
});

When to Use What

Coverage

• Target: 80%+ lines and branches
• Check: pnpm vitest run --coverage
• Critical paths (auth, payments): 100%
• Run coverage before committing

References

• See rules/common/tdd.md for detailed TDD rules