Voice guide for writing PR descriptions. Use this skill for ALL PR creation and updates (via gh CLI or editing existing PRs). Contains your specific voice rules, anti-patterns, examples, and workflow. Never write PR descriptions without invoking this skill first.
.github/PULL_REQUEST_TEMPLATE.mdgit log main..HEAD --oneline and git diff main...HEAD --statgh pr create --draft --title "..." --body "..."> [!NOTE] callout if PR depends on another PR_ separator" not "multi-entity composite perturbation"❌ Listing every file changed
❌ "Comprehensive" descriptions - less is more
❌ Automated steps in "How to validate" — never "run the tests", "run CI", or "run lint/checks"; validation must be manual only (run the real thing e2e and expect to see X evidence of correct behavior)
❌ Technical jargon when plain language works
❌ Business rule explanations (put in code comments)
❌ Placeholder links - ask for real URLs
❌ Escaped inline code like variable - variable is nicer to read
.github/PULL_REQUEST_TEMPLATE.md or .github/pull_request_template.md as base> [!NOTE]
> Builds on #142 to leverage its frontend helpers
## ✅ What
- Adds an "Include archived items" toggle to filter archived entries in/out of all views
- Includes a tooltip explaining what "archived items" are
- Hides the toggle completely if the current dataset doesn't have archived items
- Since this toggle won't appear until datasets with archived items are in prod, it's safe to deploy backend and frontend together
### 🍿 Screen recording of validation steps below
[video]
## 🤔 Why
- This dataset is the first appearance of archived items in the app
- While users gain an understanding of how to interpret these items, we want them to have the ability to hide them
## 👩🔬 How to validate
- [ ] `./bin/dev.sh` + `cd frontend` + `npm start`
- [ ] Expect to **not** see the "Include archived items" toggle
- [ ] Select a dataset with archived items
- [ ] Expect to see the toggle now
- [ ] Query a few items, including one that's archived (look for the `[archived]` badge)
- [ ] Expect to see the archived item in the list, detail view, and charts
- [ ] Toggle archived items off
- [ ] Expect the archived item's chip to be disabled
- [ ] Expect the disabled item's tooltip to explain why
- [ ] Expect the archived item to no longer appear in your views
## 🔖 Related links
- [Jira task](https://jira.example.com/browse/PROJ-123)
- [Slack thread](https://workspace.slack.com/archives/C12345/p1234567890)
✅ Dependency callout at top ✅ Screen recording before text ✅ Deployment timing mentioned ✅ User-centric Why ✅ Concrete language ✅ Narrative validation (10 steps) ✅ Real links (not placeholders)
# Check for related issues
gh issue list --state open
# Create draft PR
gh pr create --draft --title "Title" --body "$(cat <<'EOF'
[PR body here]
EOF
)"
# View PR
gh pr view --web
git log main..HEADgit diff main...HEAD --statgh pr create --draft